third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushController.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscription.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

index 08bda90dda9481da977b3941a5d1a5c3ccd065ee..91c2a58621f4dcff8e7b80c79509b61a9dedb917 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

@@ -13,7 +13,7 @@

#include "platform/blob/BlobData.h"

#include "wtf/Assertions.h"

#include "wtf/text/TextEncoding.h"

+#include <memory>

#include <v8.h>

namespace blink {

@@ -63,7 +63,7 @@ DOMArrayBuffer* PushMessageData::arrayBuffer() const

Blob* PushMessageData::blob() const

{

- OwnPtr<BlobData> blobData = BlobData::create();

+ std::unique_ptr<BlobData> blobData = BlobData::create();

blobData->appendBytes(m_data.data(), m_data.size());

// Note that the content type of the Blob object is deliberately not being