third_party/WebKit/Source/core/frame/FrameConsole.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameConsole.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameConsole.cpp b/third_party/WebKit/Source/core/frame/FrameConsole.cpp

index 2faacc352bd3ec2283b3e3c5500108362b3baeeb..ab36bd33119b6b04e132d5e7ff551ec303ff317e 100644

--- a/third_party/WebKit/Source/core/frame/FrameConsole.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameConsole.cpp

@@ -38,6 +38,7 @@

#include "platform/network/ResourceError.h"

#include "platform/network/ResourceResponse.h"

#include "wtf/text/StringBuilder.h"

+#include <memory>

namespace blink {

@@ -81,7 +82,7 @@ void FrameConsole::reportMessageToClient(ConsoleMessage* consoleMessage)

if (!frame().host())

return;

if (frame().chromeClient().shouldReportDetailedMessageForSource(frame(), url)) {

- OwnPtr<SourceLocation> location = SourceLocation::captureWithFullStackTrace();

+ std::unique_ptr<SourceLocation> location = SourceLocation::captureWithFullStackTrace();

if (!location->isUnknown())

stackTrace = location->toString();

}