third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp

index 76ae4454f41b299a6e10eeb51d03b1fe011a502e..9eca8aeac343be69b5f83734223778f99dbf639a 100644

--- a/third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp

@@ -7,6 +7,7 @@

#include "core/animation/StringKeyframe.h"

#include "core/svg/SVGRect.h"

#include "wtf/StdLibExtras.h"

+#include <memory>

namespace blink {

@@ -20,7 +21,7 @@ enum RectComponentIndex {

InterpolationValue SVGRectInterpolationType::maybeConvertNeutral(const InterpolationValue&, ConversionCheckers&) const

{

- OwnPtr<InterpolableList> result = InterpolableList::create(RectComponentIndexCount);

+ std::unique_ptr<InterpolableList> result = InterpolableList::create(RectComponentIndexCount);

for (size_t i = 0; i < RectComponentIndexCount; i++)

result->set(i, InterpolableNumber::create(0));

return InterpolationValue(std::move(result));

@@ -32,7 +33,7 @@ InterpolationValue SVGRectInterpolationType::maybeConvertSVGValue(const SVGPrope

return nullptr;

const SVGRect& rect = toSVGRect(svgValue);

- OwnPtr<InterpolableList> result = InterpolableList::create(RectComponentIndexCount);

+ std::unique_ptr<InterpolableList> result = InterpolableList::create(RectComponentIndexCount);

result->set(RectX, InterpolableNumber::create(rect.x()));

result->set(RectY, InterpolableNumber::create(rect.y()));

result->set(RectWidth, InterpolableNumber::create(rect.width()));