third_party/WebKit/Source/platform/TraceEventCommon.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/TraceEventCommon.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/TraceEventCommon.h

diff --git a/third_party/WebKit/Source/platform/TraceEventCommon.h b/third_party/WebKit/Source/platform/TraceEventCommon.h

index b38208d90ff8a93bb229c156681964df35f24775..95adddaa94f43f6cfbe28ccb05bb7bac2ff463b6 100644

--- a/third_party/WebKit/Source/platform/TraceEventCommon.h

+++ b/third_party/WebKit/Source/platform/TraceEventCommon.h

@@ -148,8 +148,8 @@

// class MyData {

// public:

// MyData() {}

-// PassOwnPtr<TracedValue> toTracedValue() {

-// OwnPtr<TracedValue> tracedValue = TracedValue::create();

+// std::unique_ptr<TracedValue> toTracedValue() {

+// std::unique_ptr<TracedValue> tracedValue = TracedValue::create();

// tracedValue->setInteger("foo", 1);

// tracedValue->beginArray("bar");

// tracedValue->pushInteger(2);