third_party/WebKit/Source/wtf/SizeLimits.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/SizeLimits.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/SizeLimits.cpp

diff --git a/third_party/WebKit/Source/wtf/SizeLimits.cpp b/third_party/WebKit/Source/wtf/SizeLimits.cpp

index 9049b47f6814a3f405a9f90dc10c9a75ee38ecd1..a0c9b0318f29bdd2ced65596d080594d76b445bb 100644

--- a/third_party/WebKit/Source/wtf/SizeLimits.cpp

+++ b/third_party/WebKit/Source/wtf/SizeLimits.cpp

@@ -30,7 +30,6 @@

#include "wtf/Assertions.h"

#include "wtf/ContainerAnnotations.h"

-#include "wtf/OwnPtr.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefCounted.h"

#include "wtf/RefPtr.h"

@@ -38,6 +37,7 @@

#include "wtf/Vector.h"

#include "wtf/text/AtomicString.h"

#include "wtf/text/WTFString.h"

+#include <memory>

namespace WTF {

@@ -77,7 +77,7 @@ struct SameSizeAsVectorWithInlineCapacity {

#endif

};

-static_assert(sizeof(OwnPtr<int>) == sizeof(int*), "OwnPtr should stay small");

+static_assert(sizeof(std::unique_ptr<int>) == sizeof(int*), "std::unique_ptr should stay small");

static_assert(sizeof(PassRefPtr<RefCounted<int>>) == sizeof(int*), "PassRefPtr should stay small");

static_assert(sizeof(RefCounted<int>) == sizeof(SameSizeAsRefCounted), "RefCounted should stay small");

static_assert(sizeof(RefPtr<RefCounted<int>>) == sizeof(int*), "RefPtr should stay small");