Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: third_party/WebKit/Source/web/PageOverlayTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/PageOverlay.cpp ('k') | third_party/WebKit/Source/web/PageWidgetDelegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/PageOverlayTest.cpp
diff --git a/third_party/WebKit/Source/web/PageOverlayTest.cpp b/third_party/WebKit/Source/web/PageOverlayTest.cpp
index 5eddde85240c99dac0c1e77c71f2ce92f5ccca69..5ada6d1fff2b4398beb9b32bf6f7260bc535bf9f 100644
--- a/third_party/WebKit/Source/web/PageOverlayTest.cpp
+++ b/third_party/WebKit/Source/web/PageOverlayTest.cpp
@@ -22,6 +22,7 @@
#include "web/WebLocalFrameImpl.h"
#include "web/WebViewImpl.h"
#include "web/tests/FrameTestHelpers.h"
+#include <memory>
using testing::_;
using testing::AtLeast;
@@ -79,7 +80,7 @@ protected:
WebViewImpl* webViewImpl() const { return m_helper.webViewImpl(); }
- PassOwnPtr<PageOverlay> createSolidYellowOverlay()
+ std::unique_ptr<PageOverlay> createSolidYellowOverlay()
{
return PageOverlay::create(webViewImpl(), new SolidColorOverlay(SK_ColorYELLOW));
}
@@ -111,7 +112,7 @@ TEST_F(PageOverlayTest, PageOverlay_AcceleratedCompositing)
initialize(AcceleratedCompositing);
webViewImpl()->layerTreeView()->setViewportSize(WebSize(viewportWidth, viewportHeight));
- OwnPtr<PageOverlay> pageOverlay = createSolidYellowOverlay();
+ std::unique_ptr<PageOverlay> pageOverlay = createSolidYellowOverlay();
pageOverlay->update();
webViewImpl()->updateAllLifecyclePhases();
@@ -141,7 +142,7 @@ TEST_F(PageOverlayTest, PageOverlay_AcceleratedCompositing)
TEST_F(PageOverlayTest, PageOverlay_VisualRect)
{
initialize(AcceleratedCompositing);
- OwnPtr<PageOverlay> pageOverlay = createSolidYellowOverlay();
+ std::unique_ptr<PageOverlay> pageOverlay = createSolidYellowOverlay();
pageOverlay->update();
webViewImpl()->updateAllLifecyclePhases();
EXPECT_EQ(LayoutRect(0, 0, viewportWidth, viewportHeight), pageOverlay->visualRect());
« no previous file with comments | « third_party/WebKit/Source/web/PageOverlay.cpp ('k') | third_party/WebKit/Source/web/PageWidgetDelegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698