third_party/WebKit/Source/core/html/HTMLVideoElement.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

index a68cc16329cda8d5a92dfc76f98cb94e83edc0e4..04ae3c0f4c4b88d04dc13ea5d87e69732cfcd376 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

@@ -46,6 +46,7 @@

#include "platform/graphics/ImageBuffer.h"

#include "platform/graphics/gpu/Extensions3DUtil.h"

#include "public/platform/WebCanvas.h"

+#include <memory>

namespace blink {

@@ -294,7 +295,7 @@ PassRefPtr<Image> HTMLVideoElement::getSourceImageForCanvas(SourceImageStatus* s

IntSize intrinsicSize(videoWidth(), videoHeight());

// FIXME: Not sure if we dhould we be doing anything with the AccelerationHint argument here?

- OwnPtr<ImageBuffer> imageBuffer = ImageBuffer::create(intrinsicSize);

+ std::unique_ptr<ImageBuffer> imageBuffer = ImageBuffer::create(intrinsicSize);

if (!imageBuffer) {

*status = InvalidSourceImageStatus;

return nullptr;