third_party/WebKit/Source/modules/push_messaging/PushSubscription.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

index be6fd12d02eaa0cd743d79021dcd2460cbe0f75a..e21dcbd17cab48ac626c0f0c10b1501dfc8f2965 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

@@ -13,6 +13,7 @@

#include "platform/weborigin/KURL.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

+#include <memory>

namespace blink {

@@ -24,7 +25,7 @@ struct WebPushSubscription;

class PushSubscription final : public GarbageCollectedFinalized<PushSubscription>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

- static PushSubscription* take(ScriptPromiseResolver*, PassOwnPtr<WebPushSubscription>, ServiceWorkerRegistration*);

+ static PushSubscription* take(ScriptPromiseResolver*, std::unique_ptr<WebPushSubscription>, ServiceWorkerRegistration*);

static void dispose(WebPushSubscription* subscriptionRaw);

virtual ~PushSubscription();