third_party/WebKit/Source/core/frame/FrameViewTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameViewTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameViewTest.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp

index c4024cd3e3d758f86a8fe348de2a4236c643f857..f5677254f6067655519c6e72679ed180e37dd41a 100644

--- a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp

@@ -17,7 +17,7 @@

#include "platform/heap/Handle.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include "wtf/OwnPtr.h"

+#include <memory>

using testing::_;

using testing::AnyNumber;

@@ -63,7 +63,7 @@ protected:

private:

Persistent<MockChromeClient> m_chromeClient;

- OwnPtr<DummyPageHolder> m_pageHolder;

+ std::unique_ptr<DummyPageHolder> m_pageHolder;

};

class FrameViewTest : public FrameViewTestBase {