third_party/WebKit/Source/core/layout/LayoutTestHelper.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTestHelper.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTestHelper.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTestHelper.h b/third_party/WebKit/Source/core/layout/LayoutTestHelper.h

index a6c0c6cac725b4d004640c2315878ab03792e34b..189a8d87d89fb7179a60317f4aa40bb0af874400 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTestHelper.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTestHelper.h

@@ -13,8 +13,8 @@

#include "core/loader/EmptyClients.h"

#include "core/testing/DummyPageHolder.h"

#include "wtf/Allocator.h"

-#include "wtf/OwnPtr.h"

#include <gtest/gtest.h>

+#include <memory>

namespace blink {

@@ -60,7 +60,7 @@ private:

Persistent<LocalFrame> m_subframe;

Persistent<FrameLoaderClient> m_frameLoaderClient;

Persistent<FrameLoaderClient> m_childFrameLoaderClient;

- OwnPtr<DummyPageHolder> m_pageHolder;

+ std::unique_ptr<DummyPageHolder> m_pageHolder;

};

class SingleChildFrameLoaderClient final : public EmptyFrameLoaderClient {