third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h

diff --git a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h b/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h

index dc11a4ce7ac288f625653775a0481069bdf74071..022879b2a7991960bcc17f3e84997ecfa49f1322 100644

--- a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h

+++ b/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h

@@ -39,6 +39,7 @@

#include "wtf/Noncopyable.h"

#include "wtf/RefPtr.h"

#include "wtf/text/WTFString.h"

+#include <memory>

class SkTypeface;

@@ -51,7 +52,7 @@ class PLATFORM_EXPORT FontCustomPlatformData {

USING_FAST_MALLOC(FontCustomPlatformData);

WTF_MAKE_NONCOPYABLE(FontCustomPlatformData);

public:

- static PassOwnPtr<FontCustomPlatformData> create(SharedBuffer*, String& otsParseMessage);

+ static std::unique_ptr<FontCustomPlatformData> create(SharedBuffer*, String& otsParseMessage);

~FontCustomPlatformData();

FontPlatformData fontPlatformData(float size, bool bold, bool italic, FontOrientation = FontOrientation::Horizontal);