third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerTee.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp

index 760cf0ea4cba8c36ecdc854d745f2dcc2e10d712..13115fe825f622516405b232ae48a25702958946 100644

--- a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp

@@ -5,6 +5,7 @@

#include "modules/fetch/DataConsumerHandleUtil.h"

#include "modules/fetch/DataConsumerHandleTestUtil.h"

+#include <memory>

namespace blink {

@@ -20,8 +21,8 @@ TEST(DataConsumerHandleUtilTest, CreateWaitingHandle)

char buffer[20];

const void* p = nullptr;

size_t size = 0;

- OwnPtr<WebDataConsumerHandle> handle = createWaitingDataConsumerHandle();

- OwnPtr<WebDataConsumerHandle::Reader> reader = handle->obtainReader(nullptr);

+ std::unique_ptr<WebDataConsumerHandle> handle = createWaitingDataConsumerHandle();

+ std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader(nullptr);

EXPECT_EQ(kShouldWait, reader->read(buffer, sizeof(buffer), kNone, &size));

EXPECT_EQ(kShouldWait, reader->beginRead(&p, kNone, &size));

@@ -40,8 +41,8 @@ TEST(DataConsumerHandleUtilTest, CreateDoneHandle)

char buffer[20];

const void* p = nullptr;

size_t size = 0;

- OwnPtr<WebDataConsumerHandle> handle = createDoneDataConsumerHandle();

- OwnPtr<WebDataConsumerHandle::Reader> reader = handle->obtainReader(nullptr);

+ std::unique_ptr<WebDataConsumerHandle> handle = createDoneDataConsumerHandle();

+ std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader(nullptr);

EXPECT_EQ(kDone, reader->read(buffer, sizeof(buffer), kNone, &size));

EXPECT_EQ(kDone, reader->beginRead(&p, kNone, &size));

@@ -67,8 +68,8 @@ TEST(DataConsumerHandleUtilTest, CreateUnexpectedErrorHandle)

char buffer[20];

const void* p = nullptr;

size_t size = 0;

- OwnPtr<WebDataConsumerHandle> handle = createUnexpectedErrorDataConsumerHandle();

- OwnPtr<WebDataConsumerHandle::Reader> reader = handle->obtainReader(nullptr);

+ std::unique_ptr<WebDataConsumerHandle> handle = createUnexpectedErrorDataConsumerHandle();

+ std::unique_ptr<WebDataConsumerHandle::Reader> reader = handle->obtainReader(nullptr);

EXPECT_EQ(kUnexpectedError, reader->read(buffer, sizeof(buffer), kNone, &size));

EXPECT_EQ(kUnexpectedError, reader->beginRead(&p, kNone, &size));