third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h

index b9bb81f441f910ea5e19083b962dd4a801bfa36e..d86fa3a8a273901ac34d9940bdd5eb5cb5cf2a0e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h

@@ -9,7 +9,8 @@

#include "bindings/core/v8/ScriptPromiseProperties.h"

#include "core/CoreExport.h"

#include "wtf/Allocator.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

+#include <memory>

#include <v8.h>

namespace blink {

@@ -61,7 +62,7 @@ class CORE_EXPORT V8HiddenValue {

USING_FAST_MALLOC(V8HiddenValue);

WTF_MAKE_NONCOPYABLE(V8HiddenValue);

public:

- static PassOwnPtr<V8HiddenValue> create() { return adoptPtr(new V8HiddenValue()); }

+ static std::unique_ptr<V8HiddenValue> create() { return wrapUnique(new V8HiddenValue()); }

#define V8_DECLARE_METHOD(name) static v8::Local<v8::String> name(v8::Isolate* isolate);

V8_HIDDEN_VALUES(V8_DECLARE_METHOD);