third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

index 08fd5c7dc390b015101fc8f823986877cebc6cf2..fd6332925709c5576a388c1407ca7798facfe1a3 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

@@ -10,15 +10,16 @@

#include "platform/fonts/UTF16TextIterator.h"

#include "platform/text/Character.h"

#include "wtf/Assertions.h"

+#include "wtf/PtrUtil.h"

namespace blink {

RunSegmenter::RunSegmenter(const UChar* buffer, unsigned bufferSize, FontOrientation runOrientation)

: m_bufferSize(bufferSize)

, m_candidateRange({ 0, 0, USCRIPT_INVALID_CODE, OrientationIterator::OrientationKeep, FontFallbackPriority::Text })

- , m_scriptRunIterator(adoptPtr(new ScriptRunIterator(buffer, bufferSize)))

- , m_orientationIterator(runOrientation == FontOrientation::VerticalMixed ? adoptPtr(new OrientationIterator(buffer, bufferSize, runOrientation)) : nullptr)

- , m_symbolsIterator(adoptPtr(new SymbolsIterator(buffer, bufferSize)))

+ , m_scriptRunIterator(wrapUnique(new ScriptRunIterator(buffer, bufferSize)))

+ , m_orientationIterator(runOrientation == FontOrientation::VerticalMixed ? wrapUnique(new OrientationIterator(buffer, bufferSize, runOrientation)) : nullptr)

+ , m_symbolsIterator(wrapUnique(new SymbolsIterator(buffer, bufferSize)))

, m_lastSplit(0)

, m_scriptRunIteratorPosition(0)

, m_orientationIteratorPosition(runOrientation == FontOrientation::VerticalMixed ? 0 : m_bufferSize)