third_party/WebKit/Source/modules/webaudio/ConvolverNode.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

index 294fde6d53a56570f4535af10aa2cf0a0cff7d96..d27be4e83af27522b3823807085bcccfc2db8d95 100644

--- a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

@@ -28,9 +28,9 @@

#include "base/gtest_prod_util.h"

#include "modules/ModulesExport.h"

#include "modules/webaudio/AudioNode.h"

-#include "wtf/OwnPtr.h"

#include "wtf/RefPtr.h"

#include "wtf/ThreadingPrimitives.h"

+#include <memory>

namespace blink {

@@ -58,7 +58,7 @@ private:

double tailTime() const override;

double latencyTime() const override;

- OwnPtr<Reverb> m_reverb;

+ std::unique_ptr<Reverb> m_reverb;

// This Persistent doesn't make a reference cycle including the owner

// ConvolverNode.

Persistent<AudioBuffer> m_buffer;