third_party/WebKit/Source/modules/presentation/PresentationConnection.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

index 130fbcf2c767afc4a383d0bfe5eeb77d6d543c35..4c1cc29aa6b61f8fd20da702d6475b40a33ce720 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

@@ -11,8 +11,8 @@

#include "core/frame/DOMWindowProperty.h"

#include "platform/heap/Handle.h"

#include "public/platform/modules/presentation/WebPresentationConnectionClient.h"

-#include "wtf/OwnPtr.h"

#include "wtf/text/WTFString.h"

+#include <memory>

namespace WTF {

class AtomicString;

@@ -32,10 +32,10 @@ class PresentationConnection final

DEFINE_WRAPPERTYPEINFO();

public:

// For CallbackPromiseAdapter.

- using WebType = OwnPtr<WebPresentationConnectionClient>;

+ using WebType = std::unique_ptr<WebPresentationConnectionClient>;

- static PresentationConnection* take(ScriptPromiseResolver*, PassOwnPtr<WebPresentationConnectionClient>, PresentationRequest*);

- static PresentationConnection* take(PresentationController*, PassOwnPtr<WebPresentationConnectionClient>, PresentationRequest*);

+ static PresentationConnection* take(ScriptPromiseResolver*, std::unique_ptr<WebPresentationConnectionClient>, PresentationRequest*);

+ static PresentationConnection* take(PresentationController*, std::unique_ptr<WebPresentationConnectionClient>, PresentationRequest*);

~PresentationConnection() override;

// EventTarget implementation.