third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

index 8f8622b89f92b11cc400305c705718b676a06418..f24144eaf158313da3e4cf038faaa687493c2caf 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

@@ -11,6 +11,7 @@

#include "core/loader/EmptyClients.h"

#include "core/testing/DummyPageHolder.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include <memory>

namespace blink {

@@ -20,7 +21,7 @@ protected:

HTMLDocument& document() const { return *m_document; }

private:

- OwnPtr<DummyPageHolder> m_dummyPageHolder;

+ std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

Persistent<HTMLDocument> m_document;

};