third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp ('k') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

diff --git a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

index 53c3b55aae7dcb93866d38745e07749bd1c39588..445c3e6ada9b2d1d7c82c86b56f327c13c86e664 100644

--- a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

+++ b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

@@ -14,9 +14,8 @@

#include "platform/heap/Visitor.h"

#include "public/platform/modules/notifications/WebNotificationManager.h"

#include "wtf/Noncopyable.h"

-#include "wtf/OwnPtr.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/PassRefPtr.h"

+#include <memory>

namespace blink {

@@ -48,8 +47,8 @@ private:

static const char* supplementName();

static ServiceWorkerRegistrationNotifications& from(ExecutionContext*, ServiceWorkerRegistration&);

- void prepareShow(const WebNotificationData&, PassOwnPtr<WebNotificationShowCallbacks>);

- void didLoadResources(PassRefPtr<SecurityOrigin>, const WebNotificationData&, PassOwnPtr<WebNotificationShowCallbacks>, NotificationResourcesLoader*);

+ void prepareShow(const WebNotificationData&, std::unique_ptr<WebNotificationShowCallbacks>);

+ void didLoadResources(PassRefPtr<SecurityOrigin>, const WebNotificationData&, std::unique_ptr<WebNotificationShowCallbacks>, NotificationResourcesLoader*);

Member<ServiceWorkerRegistration> m_registration;

HeapHashSet<Member<NotificationResourcesLoader>> m_loaders;