Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/HTMLImageElement.h" 5 #include "core/html/HTMLImageElement.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/frame/FrameView.h" 8 #include "core/frame/FrameView.h"
9 #include "core/testing/DummyPageHolder.h" 9 #include "core/testing/DummyPageHolder.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 #include <memory>
11 12
12 namespace blink { 13 namespace blink {
13 14
14 const int viewportWidth = 500; 15 const int viewportWidth = 500;
15 const int viewportHeight = 600; 16 const int viewportHeight = 600;
16 class HTMLImageElementTest : public testing::Test { 17 class HTMLImageElementTest : public testing::Test {
17 protected: 18 protected:
18 HTMLImageElementTest() 19 HTMLImageElementTest()
19 : m_dummyPageHolder(DummyPageHolder::create(IntSize(viewportWidth, viewp ortHeight))) 20 : m_dummyPageHolder(DummyPageHolder::create(IntSize(viewportWidth, viewp ortHeight)))
20 { 21 {
21 } 22 }
22 23
23 OwnPtr<DummyPageHolder> m_dummyPageHolder; 24 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
24 }; 25 };
25 26
26 TEST_F(HTMLImageElementTest, width) 27 TEST_F(HTMLImageElementTest, width)
27 { 28 {
28 HTMLImageElement* image = HTMLImageElement::create(m_dummyPageHolder->docume nt(), nullptr, /* createdByParser */ false); 29 HTMLImageElement* image = HTMLImageElement::create(m_dummyPageHolder->docume nt(), nullptr, /* createdByParser */ false);
29 image->setAttribute(HTMLNames::widthAttr, "400"); 30 image->setAttribute(HTMLNames::widthAttr, "400");
30 // TODO(yoav): `width` does not impact resourceWidth until we resolve https: //github.com/ResponsiveImagesCG/picture-element/issues/268 31 // TODO(yoav): `width` does not impact resourceWidth until we resolve https: //github.com/ResponsiveImagesCG/picture-element/issues/268
31 EXPECT_EQ(500, image->getResourceWidth().width); 32 EXPECT_EQ(500, image->getResourceWidth().width);
32 image->setAttribute(HTMLNames::sizesAttr, "100vw"); 33 image->setAttribute(HTMLNames::sizesAttr, "100vw");
33 EXPECT_EQ(500, image->getResourceWidth().width); 34 EXPECT_EQ(500, image->getResourceWidth().width);
34 } 35 }
35 36
36 TEST_F(HTMLImageElementTest, sourceSize) 37 TEST_F(HTMLImageElementTest, sourceSize)
37 { 38 {
38 HTMLImageElement* image = HTMLImageElement::create(m_dummyPageHolder->docume nt(), nullptr, /* createdByParser */ false); 39 HTMLImageElement* image = HTMLImageElement::create(m_dummyPageHolder->docume nt(), nullptr, /* createdByParser */ false);
39 image->setAttribute(HTMLNames::widthAttr, "400"); 40 image->setAttribute(HTMLNames::widthAttr, "400");
40 EXPECT_EQ(viewportWidth, image->sourceSize(*image)); 41 EXPECT_EQ(viewportWidth, image->sourceSize(*image));
41 image->setAttribute(HTMLNames::sizesAttr, "50vw"); 42 image->setAttribute(HTMLNames::sizesAttr, "50vw");
42 EXPECT_EQ(250, image->sourceSize(*image)); 43 EXPECT_EQ(250, image->sourceSize(*image));
43 } 44 }
44 45
45 } // namespace blink 46 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormElement.h ('k') | third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698