third_party/WebKit/Source/web/SpeechRecognitionClientProxy.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/SpeechRecognitionClientProxy.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp ('k') | third_party/WebKit/Source/web/SpeechRecognitionClientProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/SpeechRecognitionClientProxy.h

diff --git a/third_party/WebKit/Source/web/SpeechRecognitionClientProxy.h b/third_party/WebKit/Source/web/SpeechRecognitionClientProxy.h

index 0ff2721d0914f13e777709d7166ac6f8bcdeaf90..c23ac5fd14f57b00c4ce5ce4263107e36fd953e1 100644

--- a/third_party/WebKit/Source/web/SpeechRecognitionClientProxy.h

+++ b/third_party/WebKit/Source/web/SpeechRecognitionClientProxy.h

@@ -29,8 +29,8 @@

#include "modules/speech/SpeechRecognitionClient.h"

#include "public/web/WebSpeechRecognizerClient.h"

#include "wtf/Compiler.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/text/WTFString.h"

+#include <memory>

namespace blink {

@@ -44,7 +44,7 @@ public:

// Constructing a proxy object with a 0 WebSpeechRecognizer is safe in

// itself, but attempting to call start/stop/abort on it will crash.

- static PassOwnPtr<SpeechRecognitionClientProxy> create(WebSpeechRecognizer*);

+ static std::unique_ptr<SpeechRecognitionClientProxy> create(WebSpeechRecognizer*);

// SpeechRecognitionClient:

void start(SpeechRecognition*, const SpeechGrammarList*, const String& lang, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack*) override;