third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h

index 6acc290f3fcca573c8067530f7ef0028370564a1..b610dff6b208c2871413f287193bd11fd6e8ab4c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h

@@ -35,8 +35,8 @@

#include "bindings/core/v8/ScriptState.h"

#include "core/dom/ContextLifecycleObserver.h"

#include "core/dom/custom/V0CustomElementLifecycleCallbacks.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/PassRefPtr.h"

+#include <memory>

#include <v8.h>

namespace blink {

@@ -52,7 +52,7 @@ public:

~V8V0CustomElementLifecycleCallbacks() override;

- bool setBinding(PassOwnPtr<V0CustomElementBinding>);

+ bool setBinding(std::unique_ptr<V0CustomElementBinding>);

DECLARE_VIRTUAL_TRACE();