third_party/WebKit/Source/web/ExternalPopupMenu.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

index b9c93176a14410097fd0380bbb2648934e5fedf8..b3e73d35cf18528aaa512fd49d45b275df46a03b 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

@@ -50,6 +50,7 @@

#include "public/web/WebPopupMenuInfo.h"

#include "web/WebLocalFrameImpl.h"

#include "web/WebViewImpl.h"

+#include "wtf/PtrUtil.h"

namespace blink {

@@ -111,7 +112,7 @@ void ExternalPopupMenu::show()

#if OS(MACOSX)

const WebInputEvent* currentEvent = WebViewImpl::currentInputEvent();

if (currentEvent && currentEvent->type == WebInputEvent::MouseDown) {

- m_syntheticEvent = adoptPtr(new WebMouseEvent);

+ m_syntheticEvent = wrapUnique(new WebMouseEvent);

*m_syntheticEvent = *static_cast<const WebMouseEvent*>(currentEvent);

m_syntheticEvent->type = WebInputEvent::MouseUp;

m_dispatchEventTimer.startOneShot(0, BLINK_FROM_HERE);