third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp ('k') | third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

index 111f10e7118995a8c7a4b4cab0e2635436fb5ecf..1bfe52a9cb2b11455de703df6dcdc46bcf8917f7 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

@@ -35,8 +35,8 @@

#include "core/dom/MessagePort.h"

#include "core/workers/WorkerReportingProxy.h"

#include "platform/heap/Handle.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/PassRefPtr.h"

+#include <memory>

namespace blink {

@@ -55,16 +55,16 @@ class CORE_EXPORT InProcessWorkerObjectProxy : public WorkerReportingProxy {

USING_FAST_MALLOC(InProcessWorkerObjectProxy);

WTF_MAKE_NONCOPYABLE(InProcessWorkerObjectProxy);

public:

- static PassOwnPtr<InProcessWorkerObjectProxy> create(InProcessWorkerMessagingProxy*);

+ static std::unique_ptr<InProcessWorkerObjectProxy> create(InProcessWorkerMessagingProxy*);

~InProcessWorkerObjectProxy() override { }

- void postMessageToWorkerObject(PassRefPtr<SerializedScriptValue>, PassOwnPtr<MessagePortChannelArray>);

+ void postMessageToWorkerObject(PassRefPtr<SerializedScriptValue>, std::unique_ptr<MessagePortChannelArray>);

void postTaskToMainExecutionContext(std::unique_ptr<ExecutionContextTask>);

void confirmMessageFromWorkerObject(bool hasPendingActivity);

void reportPendingActivity(bool hasPendingActivity);

// WorkerReportingProxy overrides.

- void reportException(const String& errorMessage, PassOwnPtr<SourceLocation>) override;

+ void reportException(const String& errorMessage, std::unique_ptr<SourceLocation>) override;

void reportConsoleMessage(ConsoleMessage*) override;

void postMessageToPageInspector(const String&) override;

void postWorkerConsoleAgentEnabled() override;