third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 6add730d3ad2395fb3c571a440767098d15b674b..5b8f7664fb1613474bf0adcb9300691060be835d 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -63,6 +63,7 @@

#include "web/WebLocalFrameImpl.h"

#include "web/WebSettingsImpl.h"

#include "web/WebViewImpl.h"

+#include "wtf/PtrUtil.h"

namespace blink {

@@ -284,7 +285,7 @@ bool WebPagePopupImpl::initializePage()

m_page->settings().setAccessibilityEnabled(m_webView->page()->settings().accessibilityEnabled());

m_page->settings().setScrollAnimatorEnabled(m_webView->page()->settings().scrollAnimatorEnabled());

- provideContextFeaturesTo(*m_page, adoptPtr(new PagePopupFeaturesClient()));

+ provideContextFeaturesTo(*m_page, wrapUnique(new PagePopupFeaturesClient()));

DEFINE_STATIC_LOCAL(FrameLoaderClient, emptyFrameLoaderClient, (EmptyFrameLoaderClient::create()));

LocalFrame* frame = LocalFrame::create(&emptyFrameLoaderClient, &m_page->frameHost(), 0);

frame->setPagePopupOwner(m_popupClient->ownerElement());