third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/ConvolverNode.h ('k') | third_party/WebKit/Source/modules/webaudio/ConvolverNodeTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

index 3413e7a9225fd12eb9dd063ae824f89ca55444bc..dee1806a710d7743408f6155b144d9ff41bae2bd 100644

--- a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

@@ -22,13 +22,15 @@

* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-#include "modules/webaudio/ConvolverNode.h"

#include "bindings/core/v8/ExceptionState.h"

#include "core/dom/ExceptionCode.h"

#include "modules/webaudio/AudioBuffer.h"

#include "modules/webaudio/AudioNodeInput.h"

#include "modules/webaudio/AudioNodeOutput.h"

+#include "modules/webaudio/ConvolverNode.h"

#include "platform/audio/Reverb.h"

+#include "wtf/PtrUtil.h"

+#include <memory>

// Note about empirical tuning:

// The maximum FFT size affects reverb performance and accuracy.

@@ -127,7 +129,7 @@ void ConvolverHandler::setBuffer(AudioBuffer* buffer, ExceptionState& exceptionS

bufferBus->setSampleRate(buffer->sampleRate());

// Create the reverb with the given impulse response.

- OwnPtr<Reverb> reverb = adoptPtr(new Reverb(bufferBus.get(), ProcessingSizeInFrames, MaxFFTSize, 2, context() && context()->hasRealtimeConstraint(), m_normalize));

+ std::unique_ptr<Reverb> reverb = wrapUnique(new Reverb(bufferBus.get(), ProcessingSizeInFrames, MaxFFTSize, 2, context() && context()->hasRealtimeConstraint(), m_normalize));

{

// Synchronize with process().