third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ConsoleMessage.h ('k') | third_party/WebKit/Source/core/inspector/DOMPatchSupport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp b/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

index 4bb74a6c33a75eed685c52e6c35e5f6cbfefc3ea..19fa9dcf8b82de43870b96ecc99930fd6c3787f4 100644

--- a/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

@@ -8,7 +8,7 @@

#include "bindings/core/v8/SourceLocation.h"

#include "core/inspector/ScriptArguments.h"

#include "wtf/CurrentTime.h"

-#include "wtf/PassOwnPtr.h"

+#include <memory>

namespace blink {

@@ -40,7 +40,7 @@ ConsoleMessage* ConsoleMessage::createForConsoleAPI(MessageLevel level, MessageT

}

// static

-ConsoleMessage* ConsoleMessage::create(MessageSource source, MessageLevel level, const String& message, PassOwnPtr<SourceLocation> location, ScriptArguments* arguments)

+ConsoleMessage* ConsoleMessage::create(MessageSource source, MessageLevel level, const String& message, std::unique_ptr<SourceLocation> location, ScriptArguments* arguments)

{

return new ConsoleMessage(source, level, message, std::move(location), arguments);

}

@@ -54,7 +54,7 @@ ConsoleMessage* ConsoleMessage::create(MessageSource source, MessageLevel level,

ConsoleMessage::ConsoleMessage(MessageSource source,

MessageLevel level,

const String& message,

- PassOwnPtr<SourceLocation> location,

+ std::unique_ptr<SourceLocation> location,

ScriptArguments* arguments)

: m_source(source)

, m_level(level)