third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h

index 0103990024207dac5a0ddd44503d8a15411919b5..b912d7cb6aea7f743bc4cf934d6f9665e75c3cc2 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h

@@ -44,6 +44,7 @@

#include "public/platform/modules/serviceworker/WebServiceWorkerProvider.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h"

#include "wtf/Forward.h"

+#include <memory>

namespace blink {

@@ -72,7 +73,7 @@ public:

ScriptPromise ready(ScriptState*);

WebServiceWorkerProvider* provider() { return m_provider; }

- void registerServiceWorkerImpl(ExecutionContext*, const KURL& scriptURL, const KURL& scope, PassOwnPtr<RegistrationCallbacks>);

+ void registerServiceWorkerImpl(ExecutionContext*, const KURL& scriptURL, const KURL& scope, std::unique_ptr<RegistrationCallbacks>);

ScriptPromise registerServiceWorker(ScriptState*, const String& pattern, const RegistrationOptions&);

ScriptPromise getRegistration(ScriptState*, const String& documentURL);