third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index cdfe75ff20c5f27efd7768bba1cde486d66d1067..94b727a64180de46220d13552b3f5abe8355c1c5 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -47,6 +47,7 @@

#include "core/layout/LayoutTheme.h"

#include "core/svg/SVGPathUtilities.h"

#include "wtf/text/StringBuilder.h"

+#include <memory>

namespace blink {

@@ -1514,7 +1515,7 @@ static CSSValue* consumePath(CSSParserTokenRange& range)

return nullptr;

String pathString = functionArgs.consumeIncludingWhitespace().value().toString();

- OwnPtr<SVGPathByteStream> byteStream = SVGPathByteStream::create();

+ std::unique_ptr<SVGPathByteStream> byteStream = SVGPathByteStream::create();

if (buildByteStreamFromString(pathString, *byteStream) != SVGParseStatus::NoError

|| !functionArgs.atEnd())

return nullptr;