third_party/WebKit/Source/core/frame/Settings.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Settings.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Settings.h

diff --git a/third_party/WebKit/Source/core/frame/Settings.h b/third_party/WebKit/Source/core/frame/Settings.h

index 6ab18c6ad80aa65ed2861a036b6b3e5aaee118cd..8b909e30797a8d6636aaf468f4fb689760820aa0 100644

--- a/third_party/WebKit/Source/core/frame/Settings.h

+++ b/third_party/WebKit/Source/core/frame/Settings.h

@@ -44,6 +44,7 @@

#include "public/platform/PointerProperties.h"

#include "public/platform/WebDisplayMode.h"

#include "public/platform/WebViewportStyle.h"

+#include <memory>

namespace blink {

@@ -51,7 +52,7 @@ class CORE_EXPORT Settings {

WTF_MAKE_NONCOPYABLE(Settings);

USING_FAST_MALLOC(Settings);

public:

- static PassOwnPtr<Settings> create();

+ static std::unique_ptr<Settings> create();

GenericFontFamilySettings& genericFontFamilySettings() { return m_genericFontFamilySettings; }

void notifyGenericFontFamilyChange() { invalidate(SettingsDelegate::FontFamilyChange); }