Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: third_party/WebKit/Source/wtf/ListHashSetTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/ListHashSet.h ('k') | third_party/WebKit/Source/wtf/OwnPtr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/ListHashSetTest.cpp
diff --git a/third_party/WebKit/Source/wtf/ListHashSetTest.cpp b/third_party/WebKit/Source/wtf/ListHashSetTest.cpp
index 1c5a35455d3682128372a2184350dbe233a0ffe9..97a14431aa5fef0c67932459e7764d27b2dbab10 100644
--- a/third_party/WebKit/Source/wtf/ListHashSetTest.cpp
+++ b/third_party/WebKit/Source/wtf/ListHashSetTest.cpp
@@ -28,8 +28,10 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "wtf/LinkedHashSet.h"
#include "wtf/PassRefPtr.h"
+#include "wtf/PtrUtil.h"
#include "wtf/RefCounted.h"
#include "wtf/RefPtr.h"
+#include <memory>
#include <type_traits>
namespace WTF {
@@ -552,14 +554,14 @@ TEST(ListHashSetTest, WithOwnPtr)
{
bool deleted1 = false, deleted2 = false;
- typedef ListHashSet<OwnPtr<Dummy>> OwnPtrSet;
+ typedef ListHashSet<std::unique_ptr<Dummy>> OwnPtrSet;
OwnPtrSet set;
Dummy* ptr1 = new Dummy(deleted1);
{
// AddResult in a separate scope to avoid assertion hit,
// since we modify the container further.
- OwnPtrSet::AddResult res1 = set.add(adoptPtr(ptr1));
+ OwnPtrSet::AddResult res1 = set.add(wrapUnique(ptr1));
EXPECT_EQ(res1.storedValue->get(), ptr1);
}
@@ -567,11 +569,11 @@ TEST(ListHashSetTest, WithOwnPtr)
EXPECT_EQ(1UL, set.size());
OwnPtrSet::iterator it1 = set.find(ptr1);
EXPECT_NE(set.end(), it1);
- EXPECT_EQ(ptr1, (*it1));
+ EXPECT_EQ(ptr1, (*it1).get());
Dummy* ptr2 = new Dummy(deleted2);
{
- OwnPtrSet::AddResult res2 = set.add(adoptPtr(ptr2));
+ OwnPtrSet::AddResult res2 = set.add(wrapUnique(ptr2));
EXPECT_EQ(res2.storedValue->get(), ptr2);
}
@@ -579,7 +581,7 @@ TEST(ListHashSetTest, WithOwnPtr)
EXPECT_EQ(2UL, set.size());
OwnPtrSet::iterator it2 = set.find(ptr2);
EXPECT_NE(set.end(), it2);
- EXPECT_EQ(ptr2, (*it2));
+ EXPECT_EQ(ptr2, (*it2).get());
set.remove(ptr1);
EXPECT_TRUE(deleted1);
@@ -592,8 +594,8 @@ TEST(ListHashSetTest, WithOwnPtr)
deleted2 = false;
{
OwnPtrSet set;
- set.add(adoptPtr(new Dummy(deleted1)));
- set.add(adoptPtr(new Dummy(deleted2)));
+ set.add(wrapUnique(new Dummy(deleted1)));
+ set.add(wrapUnique(new Dummy(deleted2)));
}
EXPECT_TRUE(deleted1);
EXPECT_TRUE(deleted2);
@@ -601,14 +603,14 @@ TEST(ListHashSetTest, WithOwnPtr)
deleted1 = false;
deleted2 = false;
- OwnPtr<Dummy> ownPtr1;
- OwnPtr<Dummy> ownPtr2;
+ std::unique_ptr<Dummy> ownPtr1;
+ std::unique_ptr<Dummy> ownPtr2;
ptr1 = new Dummy(deleted1);
ptr2 = new Dummy(deleted2);
{
OwnPtrSet set;
- set.add(adoptPtr(ptr1));
- set.add(adoptPtr(ptr2));
+ set.add(wrapUnique(ptr1));
+ set.add(wrapUnique(ptr2));
ownPtr1 = set.takeFirst();
EXPECT_EQ(1UL, set.size());
ownPtr2 = set.take(ptr2);
@@ -617,8 +619,8 @@ TEST(ListHashSetTest, WithOwnPtr)
EXPECT_FALSE(deleted1);
EXPECT_FALSE(deleted2);
- EXPECT_EQ(ptr1, ownPtr1);
- EXPECT_EQ(ptr2, ownPtr2);
+ EXPECT_EQ(ptr1, ownPtr1.get());
+ EXPECT_EQ(ptr2, ownPtr2.get());
}
class CountCopy final {
« no previous file with comments | « third_party/WebKit/Source/wtf/ListHashSet.h ('k') | third_party/WebKit/Source/wtf/OwnPtr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698