Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2015 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 #ifndef V8IdleTaskRunner_h 26 #ifndef V8IdleTaskRunner_h
27 #define V8IdleTaskRunner_h 27 #define V8IdleTaskRunner_h
28 28
29 #include "core/CoreExport.h" 29 #include "core/CoreExport.h"
30 #include "gin/public/v8_idle_task_runner.h" 30 #include "gin/public/v8_idle_task_runner.h"
31 #include "platform/RuntimeEnabledFeatures.h" 31 #include "platform/RuntimeEnabledFeatures.h"
32 #include "public/platform/Platform.h" 32 #include "public/platform/Platform.h"
33 #include "public/platform/WebScheduler.h" 33 #include "public/platform/WebScheduler.h"
34 #include "public/platform/WebThread.h" 34 #include "public/platform/WebThread.h"
35 #include "public/platform/WebTraceLocation.h" 35 #include "public/platform/WebTraceLocation.h"
36 #include "wtf/OwnPtr.h" 36 #include "wtf/PtrUtil.h"
37 #include <memory>
37 38
38 namespace blink { 39 namespace blink {
39 40
40 class V8IdleTaskAdapter : public WebThread::IdleTask { 41 class V8IdleTaskAdapter : public WebThread::IdleTask {
41 USING_FAST_MALLOC(V8IdleTaskAdapter); 42 USING_FAST_MALLOC(V8IdleTaskAdapter);
42 WTF_MAKE_NONCOPYABLE(V8IdleTaskAdapter); 43 WTF_MAKE_NONCOPYABLE(V8IdleTaskAdapter);
43 public: 44 public:
44 V8IdleTaskAdapter(v8::IdleTask* task) : m_task(adoptPtr(task)) { } 45 V8IdleTaskAdapter(v8::IdleTask* task) : m_task(wrapUnique(task)) { }
45 ~V8IdleTaskAdapter() override { } 46 ~V8IdleTaskAdapter() override { }
46 void run(double delaySeconds) override 47 void run(double delaySeconds) override
47 { 48 {
48 m_task->Run(delaySeconds); 49 m_task->Run(delaySeconds);
49 } 50 }
50 private: 51 private:
51 OwnPtr<v8::IdleTask> m_task; 52 std::unique_ptr<v8::IdleTask> m_task;
52 }; 53 };
53 54
54 class V8IdleTaskRunner : public gin::V8IdleTaskRunner { 55 class V8IdleTaskRunner : public gin::V8IdleTaskRunner {
55 USING_FAST_MALLOC(V8IdleTaskRunner); 56 USING_FAST_MALLOC(V8IdleTaskRunner);
56 WTF_MAKE_NONCOPYABLE(V8IdleTaskRunner); 57 WTF_MAKE_NONCOPYABLE(V8IdleTaskRunner);
57 public: 58 public:
58 V8IdleTaskRunner(WebScheduler* scheduler) : m_scheduler(scheduler) { } 59 V8IdleTaskRunner(WebScheduler* scheduler) : m_scheduler(scheduler) { }
59 ~V8IdleTaskRunner() override { } 60 ~V8IdleTaskRunner() override { }
60 void PostIdleTask(v8::IdleTask* task) override 61 void PostIdleTask(v8::IdleTask* task) override
61 { 62 {
62 ASSERT(RuntimeEnabledFeatures::v8IdleTasksEnabled()); 63 ASSERT(RuntimeEnabledFeatures::v8IdleTasksEnabled());
63 m_scheduler->postIdleTask(BLINK_FROM_HERE, new V8IdleTaskAdapter(task)); 64 m_scheduler->postIdleTask(BLINK_FROM_HERE, new V8IdleTaskAdapter(task));
64 } 65 }
65 private: 66 private:
66 WebScheduler* m_scheduler; 67 WebScheduler* m_scheduler;
67 }; 68 };
68 69
69 70
70 } // namespace blink 71 } // namespace blink
71 72
72 #endif // V8Initializer_h 73 #endif // V8Initializer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698