Moving GraphicsContext and dependencies from core to platform.

Moving GraphcisContext and dependencies from core to platform.

The files in this move are all those, and only those, that must
be moved in order to move GraphicsContext without introducing layering
violations.

All font-related classes have been moved to fonts.

Image related classes have still to be moved to images.

Scroll related classes have been moved to scroll.

Some Skia classes have been moved to graphics/skia.

Some other code cleanup was done.

Some test files that rely on Platform features (current working
directory, feature enabled checking, and threading) have been moved
to web/tests. Some can be moved back when some of those Platform
test features are added back to blink_platform_unittests (patch
in preparation).

R=abarth@chromium.org, abarth, senorblanco
BUG=303332
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163315

[Stephen Chennney, 2013-12-02 22:25:37]

This probably doesn't compile on all platforms. Tested only on Linux at this
point.

I'm not even sure if it all uploaded correctly.

In any event, I'll give the try bots a whirl.

[Stephen Chennney, 2013-12-05 16:51:04]

This is ready for review. Honestly, I think only the gyp changes and gypi files
are of real interest, as they reveal what moved and they involved the
potentially contentious changes.

The raw patch in in Drive, which can be downloaded and applied to a clean
checkout using 
  patch -p1 < issue99103006.patch.txt

https://drive.google.com/file/d/0B8CjkkCMz241RFZtM01TeTlzSG8/edit?usp=sharing

[Stephen Chennney, 2013-12-05 17:19:15]

https://drive.google.com/file/d/0B8CjkkCMz241T1RSeTJveEluLVU/edit?usp=sharing

[abarth-chromium, 2013-12-05 17:21:16]

rslgtm

[Stephen White, 2013-12-05 19:28:08]

https://codereview.chromium.org/99103006/diff/120001/Source/platform/blink_pl...
File Source/platform/blink_platform.gyp (right):

https://codereview.chromium.org/99103006/diff/120001/Source/platform/blink_pl...
Source/platform/blink_platform.gyp:47: 'all_dependent_settings': {
I'm no gyp jedi, but I do see that "all_dependent_settings" is rarely used in
Blink (two places, and never for include paths). Are you sure this the right way
to accomplish this?

[Stephen White, 2013-12-05 20:50:54]

General comment: I'd much prefer if huge file move CLs were kept to just moves.
Finding where "some other code cleanup was done" is a needle in this haystack.

[Stephen Chennney, 2013-12-05 21:27:03]

On 2013/12/05 19:28:08, Stephen White wrote:
>
https://codereview.chromium.org/99103006/diff/120001/Source/platform/blink_pl...
> File Source/platform/blink_platform.gyp (right):
> 
>
https://codereview.chromium.org/99103006/diff/120001/Source/platform/blink_pl...
> Source/platform/blink_platform.gyp:47: 'all_dependent_settings': {
> I'm no gyp jedi, but I do see that "all_dependent_settings" is rarely used in
> Blink (two places, and never for include paths). Are you sure this the right
way
> to accomplish this?

I spent two days trying to find some other way to do this, with no luck at all.

The issue is that the libjpeg_turbo library has a file named config.h in it's
include path, and it is almost impossible to structure GYP files such that the
blink include path for Source/config.h always appears first. This makes sure it
happens. GYP is a black box for debugging purposes, which is super frustrating.
As far as I can tell, it only uses "include_files" paths found inside target
blocks for the target itself - they do not seem to be exported in the same way
they are used to build the target. At least, that's what I inferred.

What I really want to do is rename Source/config.h to Source/BlinkConfig.h,
which is what any sane software package would have.

[Stephen Chennney, 2013-12-05 21:33:13]

On 2013/12/05 20:50:54, Stephen White wrote:
> General comment: I'd much prefer if huge file move CLs were kept to just
moves.
> Finding where "some other code cleanup was done" is a needle in this haystack.

From memory...

I split image-decoders/ImageFrame.h out of image-decoders/ImageDecoder.h
I moved the global fontCache method to be a static member of FontCache.
I renamed FakeGraphcisContext3D to MockGraphicsContext3D. In hindsight I would
not do this again, but don't let it hold this up. I'll undo it or rename all the
"Fake" methods to "Mock" later.

Apart from adding WTF_MAKE_NONCOPYABLE to a bunch of things to remove Windows
build errors, that's it.

Our tools fail dismally on patches this large.

There's still one more update to come. I fixed the Android build with another
piece of GYP magic that makes no sense to me, but which apparently is strictly
necessary.

[eseidel, 2013-12-05 21:34:29]

I would happily r+ a CL to rename config.h to something else.

[Stephen Chennney, 2013-12-05 21:38:56]

On 2013/12/05 21:34:29, eseidel wrote:
> I would happily r+ a CL to rename config.h to something else.

We'd have to create a copy side-by-side and then transition in pieces. Messy but
the only way to do it sensibly. Just look at what happened to this CL.

[Stephen White, 2013-12-05 22:24:15]

BTW, I should've mentioned off the top: I'm very excited to see this move
happen, and I know it must've been a heroic amount of work!

[Stephen Chennney, 2013-12-06 00:14:19]

On 2013/12/05 22:24:15, Stephen White wrote:
> BTW, I should've mentioned off the top: I'm very excited to see this move
> happen, and I know it must've been a heroic amount of work!

Best part is that I think it frees up almost everything else to move. That's a
win because I don't have to do it!

[Stephen Chennney, 2013-12-06 12:31:26]

Committed patchset #4 manually as r163315.

[Nico, 2013-12-09 17:36:05]

https://codereview.chromium.org/99103006/diff/120001/Source/platform/blink_pl...
File Source/platform/blink_platform.gyp (right):

https://codereview.chromium.org/99103006/diff/120001/Source/platform/blink_pl...
Source/platform/blink_platform.gyp:47: 'all_dependent_settings': {
On 2013/12/05 19:28:12, Stephen White wrote:
> I'm no gyp jedi, but I do see that "all_dependent_settings" is rarely used in
> Blink (two places, and never for include paths). Are you sure this the right
way
> to accomplish this?

+1.

https://codereview.chromium.org/99103006/diff/120001/Source/platform/blink_pl...
Source/platform/blink_platform.gyp:342: '-fno-strict-aliasing',
You don't need this, it's set globally for all projects in build/common.gypi