Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sadrul, abhishekbh_chromium.org, achuith+watch_chromium.org, sebsg+autofillwatch_chromium.org, raymes+watch_chromium.org, Patrick Dubroy, nona+watch_chromium.org, rlp+watch_chromium.org, kalyank, tbansal+watch-data-reduction-proxy_chromium.org, mlamouri+watch-content_chromium.org, ntp-dev+reviews_chromium.org, yamaguchi+watch_chromium.org, vabr+watchlistautofill_chromium.org, pam+watch_chromium.org, mlamouri+watch-permissions_chromium.org, dbeam+watch-downloads_chromium.org, hashimoto+watch_chromium.org, tfarina, estade+watch_chromium.org, pfeldman, asanka, vmpstr+watch_chromium.org, phoglund+watch_chromium.org, lhchavez+watch_chromium.org, fukino+watch_chromium.org, Matt Giuca, tommycli, samuong+watch_chromium.org, jam, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, alemate+watch_chromium.org, timvolodine, feature-vr-reviews_chromium.org, asvitkine+watch_chromium.org, michaelpg+watch-options_chromium.org, Lei Zhang, jshin+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, yusukes+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, hidehiko+watch_chromium.org, oka+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, net-reviews_chromium.org, extensions-reviews_chromium.org, ios-reviews_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, rouslan+autofill_chromium.org, rouslan+spell_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, Kevin Cernekee, sync-reviews_chromium.org, chfremer+watch_chromium.org, Dirk Pranke, wfh+watch_chromium.org, shuchen+watch_chromium.org, Aaron Boodman, victorhsieh+watch_chromium.org, noyau+watch_chromium.org, davemoore+watch_chromium.org, qsr+mojo_chromium.org, chromoting-reviews_chromium.org, rogerm+autofillwatch_chromium.org, agrieve+watch_chromium.org, stevenjb+watch_chromium.org, darin (slow to review), cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, Sameer Nanda, dbeam+watch-options_chromium.org, poromov+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, cc-bugs_chromium.org, elijahtaylor+arcwatch_chromium.org, mathp+autofillwatch_chromium.org, nektar+watch_chromium.org, dbeam+watch-history_chromium.org, dbeam+watch-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change base::Value::ListStorage to std::vector<base::Value> (patchset #14 id:260001 of https://codereview.chromium.org/2740143002/ ) Reason for revert: Appears to have broken compile on ChromeOS. Needs a rebase? FAILED: obj/extensions/browser/api/networking_private/networking_private/networking_private_chromeos.o In file included from ../../extensions/browser/api/networking_private/networking_private_chromeos.cc:21: In file included from ../../chromeos/network/network_connection_handler.h:18: In file included from ../../chromeos/cert_loader.h:18: In file included from ../../net/cert/cert_database.h:13: ../../net/cert/x509_certificate.h:22:10: fatal error: 'net/net_features.h' file not found #include "net/net_features.h" ^~~~~~~~~~~~~~~~~~~~ 1 error generated. https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/32152 Original issue's description: > Change base::Value::ListStorage to std::vector<base::Value> > > This CL is a first step to inlining base::ListValue. It is proposed to use an > std::vector<base::Value> as the underlying ListStorage. This CL implements the > change and updates the code accordingly. > > TBR=bajones@chromium.org, dbeam@chromium.org, stevenjb@chromium.org > BUG=646113 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2740143002 > Cr-Commit-Position: refs/heads/master@{#463618} > Committed: https://chromium.googlesource.com/chromium/src/+/ebab0defaea3aed024283a64088ebc0cd352b47f TBR=brettw@chromium.org,rdevlin.cronin@chromium.org,flackr@chromium.org,skym@chromium.org,rsesek@chromium.org,bajones@chromium.org,dbeam@chromium.org,stevenjb@chromium.org,jdoerrie@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=646113 Review-Url: https://codereview.chromium.org/2816513002 Cr-Commit-Position: refs/heads/master@{#463630} Committed: https://chromium.googlesource.com/chromium/src/+/df600cdcab705df0e7a43823c1bca99924542cb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -646 lines) Patch
M base/json/json_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/gtest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_argument.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M base/trace_event/trace_event_memory_overhead.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/values.h View 2 chunks +1 line, -7 lines 0 comments Download
M base/values.cc View 12 chunks +58 lines, -43 lines 0 comments Download
M base/values_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_json_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/gltf_parser.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/key_permissions.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printing/printers_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/devtools/device/devtools_device_discovery.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/extensions/install_signer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/policy_handlers.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chromeos_login_media_access_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 8 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/permissions/chooser_context_base.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_finder_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_printer_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_site_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/preferences_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 3 chunks +95 lines, -111 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/certificates_handler.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/site_settings_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/common_extension_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/url_handlers/url_handlers_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/linked_app_icons.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/network_conditions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/logging.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/performance_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/nss_decryptor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/crash/linux/crash_testing_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/crash/linux/synchronized_minidump_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/shill_client_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_ipconfig_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/geolocation_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_sms_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_mapper.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_merger.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_utils.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chromeos/network/onc/onc_utils_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/policy_applicator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/prohibited_technologies_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chromeos/network/shill_property_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/printing/ppd_provider.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chromeos/system/statistics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/content/browser/risk/fingerprint.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_address_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/error_page/common/localized_error.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/flags_ui/pref_service_flags_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/category_rankers/click_based_category_ranker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/ntp_snippets/pref_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestion.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/policy/core/browser/configuration_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/url_blacklist_policy_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/registry_dict.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/prefs/pref_member.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_data_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/signin/core/browser/account_tracker_service.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/about_sync_util.cc View 13 chunks +0 lines, -62 lines 0 comments Download
M components/sync/syncable/model_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/fake_server_verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_preferences/pref_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/update_client/component_patcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_matcher/url_matcher_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_auralinux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/browsing_data/clear_site_data_throttle.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/background_tracing_config_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/webrtc/webrtc_getusermedia_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/webrtc/webrtc_internals.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/webrtc/webrtc_internals_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/gpu/actions_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/fuzzer/renderer_tree_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/values_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative/declarative_api.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/device_permissions_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/storage/storage_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_network/system_network_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/verified_contents.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M extensions/common/api/declarative/declarative_manifest_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/extension_l10n_util_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/manifest_handlers/action_handlers_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/kiosk_mode_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/requirements_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_binding.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/api_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_signature.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/argument_spec.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/public/internal/value_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/autofill_agent.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/common/values_struct_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_request_headers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/spawned_test_server/local_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/http_ice_config_request.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/test/host_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/host_list_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/catalog/entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_desc.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 3 chunks +4 lines, -9 lines 0 comments Download
M tools/json_schema_compiler/util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/search/history_data_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/manager/json_converter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
please use gerrit instead
Created Revert of Change base::Value::ListStorage to std::vector<base::Value>
3 years, 8 months ago (2017-04-11 14:52:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816513002/1
3 years, 8 months ago (2017-04-11 14:53:22 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 14:59:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df600cdcab705df0e7a43823c1bc...

Powered by Google App Engine
This is Rietveld 408576698