extensions/renderer/argument_spec.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/argument_spec.cc

diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc

index 18367145d9e1073b5f93ff2e02f437c45a6ea312..b0cb7c3aa46abed98e0d562bc71ac172be73aa28 100644

--- a/extensions/renderer/argument_spec.cc

+++ b/extensions/renderer/argument_spec.cc

@@ -60,7 +60,7 @@

type_ = ArgumentType::CHOICES;

choices_.reserve(choices->GetSize());

for (const auto& choice : *choices)

- choices_.push_back(base::MakeUnique<ArgumentSpec>(choice));

+ choices_.push_back(base::MakeUnique<ArgumentSpec>(*choice));

return;

}

« no previous file with comments | « extensions/renderer/api_signature.cc ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »