chrome/test/chromedriver/chrome/network_conditions.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/network_conditions.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/network_conditions.cc

diff --git a/chrome/test/chromedriver/chrome/network_conditions.cc b/chrome/test/chromedriver/chrome/network_conditions.cc

index bc28c9e7943ec8708622da24d834fbda268d30fa..86166eb21e82dd8677c39e7834bc35194b48571b 100644

--- a/chrome/test/chromedriver/chrome/network_conditions.cc

+++ b/chrome/test/chromedriver/chrome/network_conditions.cc

@@ -39,7 +39,7 @@

it != networks->end();

++it) {

base::DictionaryValue* network = NULL;

- if (!it->GetAsDictionary(&network)) {

+ if (!(*it)->GetAsDictionary(&network)) {

return Status(kUnknownError,

"malformed network in list: should be a dictionary");

}