Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: content/browser/accessibility/accessibility_tree_formatter_win.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/accessibility/accessibility_tree_formatter.h" 5 #include "content/browser/accessibility/accessibility_tree_formatter.h"
6 6
7 #include <oleacc.h> 7 #include <oleacc.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 } 397 }
398 case base::Value::Type::LIST: { 398 case base::Value::Type::LIST: {
399 // Currently all list values are string and are written without 399 // Currently all list values are string and are written without
400 // attribute names. 400 // attribute names.
401 const base::ListValue* list_value; 401 const base::ListValue* list_value;
402 value->GetAsList(&list_value); 402 value->GetAsList(&list_value);
403 for (base::ListValue::const_iterator it = list_value->begin(); 403 for (base::ListValue::const_iterator it = list_value->begin();
404 it != list_value->end(); 404 it != list_value->end();
405 ++it) { 405 ++it) {
406 base::string16 string_value; 406 base::string16 string_value;
407 if (it->GetAsString(&string_value)) 407 if ((*it)->GetAsString(&string_value))
408 WriteAttribute(false, string_value, &line); 408 WriteAttribute(false, string_value, &line);
409 } 409 }
410 break; 410 break;
411 } 411 }
412 case base::Value::Type::DICTIONARY: { 412 case base::Value::Type::DICTIONARY: {
413 // Currently all dictionary values are coordinates. 413 // Currently all dictionary values are coordinates.
414 // Revisit this if that changes. 414 // Revisit this if that changes.
415 const base::DictionaryValue* dict_value; 415 const base::DictionaryValue* dict_value;
416 value->GetAsDictionary(&dict_value); 416 value->GetAsDictionary(&dict_value);
417 if (strcmp(attribute_name, "size") == 0) { 417 if (strcmp(attribute_name, "size") == 0) {
(...skipping 28 matching lines...) Expand all
446 446
447 const std::string AccessibilityTreeFormatterWin::GetAllowString() { 447 const std::string AccessibilityTreeFormatterWin::GetAllowString() {
448 return "@WIN-ALLOW:"; 448 return "@WIN-ALLOW:";
449 } 449 }
450 450
451 const std::string AccessibilityTreeFormatterWin::GetDenyString() { 451 const std::string AccessibilityTreeFormatterWin::GetDenyString() {
452 return "@WIN-DENY:"; 452 return "@WIN-DENY:";
453 } 453 }
454 454
455 } // namespace content 455 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698