Revert of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/component_updater/sw_reporter_installer_win.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/sw_reporter_installer_win.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 191 matching lines @@
   if (!launch_params->GetAsList(&parameter_list) || parameter_list->empty()) {
     ReportExperimentError(SW_REPORTER_EXPERIMENT_ERROR_BAD_PARAMS);
     return;
   }
 
   const std::string session_id = GenerateSessionId();
 
   safe_browsing::SwReporterQueue invocations;
   for (const auto& iter : *parameter_list) {
     const base::DictionaryValue* invocation_params = nullptr;
-    if (!iter.GetAsDictionary(&invocation_params)) {
+    if (!iter->GetAsDictionary(&invocation_params)) {
       ReportExperimentError(SW_REPORTER_EXPERIMENT_ERROR_BAD_PARAMS);
       return;
     }
 
     // Max length of the registry and histogram suffix. Fairly arbitrary: the
     // Windows registry accepts much longer keys, but we need to display this
     // string in histograms as well.
     constexpr size_t kMaxSuffixLength = 80;
 
     // The suffix must be an alphanumeric string. (Empty is fine as long as the
@@ skipping 10 matching lines @@
     // it's ok if it's an empty list or a list of empty strings.)
     const base::ListValue* arguments = nullptr;
     if (!invocation_params->GetList("arguments", &arguments)) {
       ReportExperimentError(SW_REPORTER_EXPERIMENT_ERROR_BAD_PARAMS);
       return;
     }
 
     std::vector<base::string16> argv = {exe_path.value()};
     for (const auto& value : *arguments) {
       base::string16 argument;
-      if (!value.GetAsString(&argument)) {
+      if (!value->GetAsString(&argument)) {
         ReportExperimentError(SW_REPORTER_EXPERIMENT_ERROR_BAD_PARAMS);
         return;
       }
       if (!argument.empty())
         argv.push_back(argument);
     }
 
     base::CommandLine command_line(argv);
 
     // Add a random session id to link experimental reporter runs together.
@@ skipping 241 matching lines @@
 }
 
 void RegisterProfilePrefsForSwReporter(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterStringPref(prefs::kSwReporterPromptVersion, "");
 
   registry->RegisterStringPref(prefs::kSwReporterPromptSeed, "");
 }
 
 }  // namespace component_updater