Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/printing/cloud_print/cloud_print_printer_list.h" 5 #include "chrome/browser/printing/cloud_print/cloud_print_printer_list.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/common/cloud_print/cloud_print_constants.h" 8 #include "chrome/common/cloud_print/cloud_print_constants.h"
9 #include "components/cloud_devices/common/cloud_devices_urls.h" 9 #include "components/cloud_devices/common/cloud_devices_urls.h"
10 10
(...skipping 14 matching lines...) Expand all
25 void CloudPrintPrinterList::OnGCDApiFlowComplete( 25 void CloudPrintPrinterList::OnGCDApiFlowComplete(
26 const base::DictionaryValue& value) { 26 const base::DictionaryValue& value) {
27 const base::ListValue* printers; 27 const base::ListValue* printers;
28 if (!value.GetList(cloud_print::kPrinterListValue, &printers)) { 28 if (!value.GetList(cloud_print::kPrinterListValue, &printers)) {
29 delegate_->OnDeviceListUnavailable(); 29 delegate_->OnDeviceListUnavailable();
30 return; 30 return;
31 } 31 }
32 32
33 DeviceList devices; 33 DeviceList devices;
34 for (const auto& printer : *printers) { 34 for (const auto& printer : *printers) {
35 const base::DictionaryValue* printer_dict; 35 base::DictionaryValue* printer_dict;
36 if (!printer.GetAsDictionary(&printer_dict)) 36 if (!printer->GetAsDictionary(&printer_dict))
37 continue; 37 continue;
38 38
39 Device printer_details; 39 Device printer_details;
40 if (!FillPrinterDetails(*printer_dict, &printer_details)) 40 if (!FillPrinterDetails(*printer_dict, &printer_details))
41 continue; 41 continue;
42 42
43 devices.push_back(printer_details); 43 devices.push_back(printer_details);
44 } 44 }
45 45
46 delegate_->OnDeviceListReady(devices); 46 delegate_->OnDeviceListReady(devices);
(...skipping 20 matching lines...) Expand all
67 } 67 }
68 68
69 // Non-essential. 69 // Non-essential.
70 printer_value.GetString(cloud_print::kPrinterDescValue, 70 printer_value.GetString(cloud_print::kPrinterDescValue,
71 &printer_details->description); 71 &printer_details->description);
72 72
73 return true; 73 return true;
74 } 74 }
75 75
76 } // namespace cloud_print 76 } // namespace cloud_print
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698