Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/common/manifest_handlers/action_handlers_handler.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/action_handlers_handler.cc
diff --git a/extensions/common/manifest_handlers/action_handlers_handler.cc b/extensions/common/manifest_handlers/action_handlers_handler.cc
index c5ac38d6f72d36ca34f943c014610ffe88a8ef88..2d303181183a8c98030968bd029d323f6d178bcd 100644
--- a/extensions/common/manifest_handlers/action_handlers_handler.cc
+++ b/extensions/common/manifest_handlers/action_handlers_handler.cc
@@ -42,9 +42,9 @@
}
auto info = base::MakeUnique<ActionHandlersInfo>();
- for (const base::Value& wrapped_value : *entries) {
+ for (const std::unique_ptr<base::Value>& wrapped_value : *entries) {
std::string value;
- if (!wrapped_value.GetAsString(&value)) {
+ if (!wrapped_value->GetAsString(&value)) {
*error = base::ASCIIToUTF16(errors::kInvalidActionHandlersType);
return false;
}
« no previous file with comments | « extensions/common/extension_l10n_util_unittest.cc ('k') | extensions/common/manifest_handlers/kiosk_mode_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698