Revert of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/sync/test/integration/preferences_helper.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/preferences_helper.h"
 
 #include <utility>
 
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 59 matching lines @@
 
 void ChangeListPref(int index,
                     const char* pref_name,
                     const base::ListValue& new_value) {
   {
     ListPrefUpdate update(GetPrefs(index), pref_name);
     base::ListValue* list = update.Get();
     for (base::ListValue::const_iterator it = new_value.begin();
          it != new_value.end();
          ++it) {
-      list->Append(it->CreateDeepCopy());
+      list->Append((*it)->CreateDeepCopy());
     }
   }
 
   if (test()->use_verifier()) {
     ListPrefUpdate update_verifier(GetVerifierPrefs(), pref_name);
     base::ListValue* list_verifier = update_verifier.Get();
     for (base::ListValue::const_iterator it = new_value.begin();
          it != new_value.end();
          ++it) {
-      list_verifier->Append(it->CreateDeepCopy());
+      list_verifier->Append((*it)->CreateDeepCopy());
     }
   }
 }
 
 bool BooleanPrefMatches(const char* pref_name) {
   bool reference_value;
   if (test()->use_verifier()) {
     reference_value = GetVerifierPrefs()->GetBoolean(pref_name);
   } else {
     reference_value = GetPrefs(0)->GetBoolean(pref_name);
@@ skipping 160 matching lines @@
 bool IntegerPrefMatchChecker::IsExitConditionSatisfied() {
   return preferences_helper::IntegerPrefMatches(GetPath());
 }
 
 StringPrefMatchChecker::StringPrefMatchChecker(const char* path)
     : PrefMatchChecker(path) {}
 
 bool StringPrefMatchChecker::IsExitConditionSatisfied() {
   return preferences_helper::StringPrefMatches(GetPath());
 }