chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc

diff --git a/chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc b/chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc

index 861af6431e3b0ae1eddcf17904bc93a5e8d2938f..54e282628c1ffc3980894efbd022645929e72161 100644

--- a/chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc

+++ b/chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc

@@ -87,7 +87,7 @@

it != values->end(); ++it) {

const base::DictionaryValue* dict;

MediaDeviceInfo device;

- ASSERT_TRUE(it->GetAsDictionary(&dict));

+ ASSERT_TRUE((*it)->GetAsDictionary(&dict));

ASSERT_TRUE(dict->GetString("deviceId", &device.device_id));

ASSERT_TRUE(dict->GetString("kind", &device.kind));

ASSERT_TRUE(dict->GetString("label", &device.label));