Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: extensions/common/extension_l10n_util_unittest.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_l10n_util_unittest.cc
diff --git a/extensions/common/extension_l10n_util_unittest.cc b/extensions/common/extension_l10n_util_unittest.cc
index 81d7d78f7f00949c64c5487901ba2977eb95cb28..3caba365958e17b44483c173ecbbe6a4e21157b1 100644
--- a/extensions/common/extension_l10n_util_unittest.cc
+++ b/extensions/common/extension_l10n_util_unittest.cc
@@ -428,9 +428,8 @@
manifest.SetString(keys::kDescription, "__MSG_description__");
base::ListValue* handlers = new base::ListValue();
manifest.Set(keys::kFileBrowserHandlers, handlers);
- handlers->Append(base::MakeUnique<base::DictionaryValue>());
- base::DictionaryValue* handler = nullptr;
- handlers->GetDictionary(0, &handler);
+ base::DictionaryValue* handler = new base::DictionaryValue();
+ handlers->Append(base::WrapUnique(handler));
handler->SetString(keys::kPageActionDefaultTitle,
"__MSG_file_handler_title__");

Powered by Google App Engine
This is Rietveld 408576698