components/policy/core/common/policy_loader_win.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_loader_win.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/policy_loader_win.cc

diff --git a/components/policy/core/common/policy_loader_win.cc b/components/policy/core/common/policy_loader_win.cc

index b5ff23fa626c82ca4386f317f792f075a5424832..d86ae5dc1ef85fa6aba9927d72f2ae5144acc2e6 100644

--- a/components/policy/core/common/policy_loader_win.cc

+++ b/components/policy/core/common/policy_loader_win.cc

@@ -113,7 +113,7 @@

std::unique_ptr<base::ListValue> filtered_values(new base::ListValue);

for (const auto& list_entry : *policy_list_value) {

std::string entry;

- if (!list_entry.GetAsString(&entry))

+ if (!list_entry->GetAsString(&entry))

continue;

size_t pos = entry.find(';');

if (pos == std::string::npos)