Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7736)

Unified Diff: chrome/service/cloud_print/printer_job_queue_handler.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/printer_job_queue_handler.cc
diff --git a/chrome/service/cloud_print/printer_job_queue_handler.cc b/chrome/service/cloud_print/printer_job_queue_handler.cc
index 64aa593b1c18bcfc33e1d62c2055d0419485b6d9..4757bd9344a49a97fbb6905ce41c2f6c246199df 100644
--- a/chrome/service/cloud_print/printer_job_queue_handler.cc
+++ b/chrome/service/cloud_print/printer_job_queue_handler.cc
@@ -120,7 +120,7 @@
std::vector<JobDetails> jobs_with_timeouts;
for (const auto& job_value : *job_list) {
const base::DictionaryValue* job_data = nullptr;
- if (!job_value.GetAsDictionary(&job_data))
+ if (!job_value->GetAsDictionary(&job_data))
continue;
JobDetails job_details_current = ConstructJobDetailsFromJson(*job_data);
« no previous file with comments | « chrome/common/extensions/manifest_handlers/linked_app_icons.cc ('k') | chrome/test/chromedriver/chrome/network_conditions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698