Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: chrome/browser/permissions/chooser_context_base.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/predictor_unittest.cc ('k') | chrome/browser/plugins/plugin_finder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/chooser_context_base.cc
diff --git a/chrome/browser/permissions/chooser_context_base.cc b/chrome/browser/permissions/chooser_context_base.cc
index 1214898c8b39f6663cc98437009b551179c40efe..3b99bad21385d39261562354ae5a096ce8d65c9f 100644
--- a/chrome/browser/permissions/chooser_context_base.cc
+++ b/chrome/browser/permissions/chooser_context_base.cc
@@ -58,8 +58,7 @@
for (auto& object : *object_list) {
// Steal ownership of |object| from |object_list|.
std::unique_ptr<base::DictionaryValue> object_dict =
- base::DictionaryValue::From(
- base::MakeUnique<base::Value>(std::move(object)));
+ base::DictionaryValue::From(std::move(object));
if (object_dict && IsValidObject(*object_dict))
results.push_back(std::move(object_dict));
}
@@ -85,9 +84,9 @@
if (!setting->GetList(kObjectListKey, &object_list))
continue;
- for (auto& object : *object_list) {
+ for (const auto& object : *object_list) {
base::DictionaryValue* object_dict;
- if (!object.GetAsDictionary(&object_dict) ||
+ if (!object->GetAsDictionary(&object_dict) ||
!IsValidObject(*object_dict)) {
continue;
}
« no previous file with comments | « chrome/browser/net/predictor_unittest.cc ('k') | chrome/browser/plugins/plugin_finder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698