Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: content/browser/browsing_data/clear_site_data_throttle.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browsing_data/clear_site_data_throttle.cc
diff --git a/content/browser/browsing_data/clear_site_data_throttle.cc b/content/browser/browsing_data/clear_site_data_throttle.cc
index eec778fefe8817f0cd238840f61ac4629ed37840..00e57cef1fd0bd7e7047934bcbee01ab5977f7ab 100644
--- a/content/browser/browsing_data/clear_site_data_throttle.cc
+++ b/content/browser/browsing_data/clear_site_data_throttle.cc
@@ -206,9 +206,9 @@
*clear_cache = false;
std::vector<std::string> type_names;
- for (const base::Value& value : *types) {
+ for (const std::unique_ptr<base::Value>& value : *types) {
std::string type;
- value.GetAsString(&type);
+ value->GetAsString(&type);
bool* datatype = nullptr;
@@ -221,7 +221,7 @@
} else {
std::string serialized_type;
JSONStringValueSerializer serializer(&serialized_type);
- serializer.Serialize(value);
+ serializer.Serialize(*value);
ConsoleLog(
messages, current_url_,
base::StringPrintf("Invalid type: %s.", serialized_type.c_str()),

Powered by Google App Engine
This is Rietveld 408576698