Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: chromeos/dbus/shill_ipconfig_client.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_client_helper.cc ('k') | chromeos/network/geolocation_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_ipconfig_client.cc
diff --git a/chromeos/dbus/shill_ipconfig_client.cc b/chromeos/dbus/shill_ipconfig_client.cc
index c58c0c06fbab3c517ae43af37f5b387b2bbc5634..84c1e1a11b18ff8ff566b4943ce3e4c1832817b4 100644
--- a/chromeos/dbus/shill_ipconfig_client.cc
+++ b/chromeos/dbus/shill_ipconfig_client.cc
@@ -126,10 +126,10 @@
for (base::ListValue::const_iterator it = list_value->begin();
it != list_value->end();
++it) {
- DLOG_IF(ERROR, it->GetType() != base::Value::Type::STRING)
- << "Unexpected type " << it->GetType();
+ DLOG_IF(ERROR, (*it)->GetType() != base::Value::Type::STRING)
+ << "Unexpected type " << (*it)->GetType();
std::string str;
- it->GetAsString(&str);
+ (*it)->GetAsString(&str);
array_writer.AppendString(str);
}
variant_writer.CloseContainer(&array_writer);
« no previous file with comments | « chromeos/dbus/shill_client_helper.cc ('k') | chromeos/network/geolocation_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698