Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4141)

Unified Diff: chrome/browser/metrics/plugin_metrics_provider.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/plugin_metrics_provider.cc
diff --git a/chrome/browser/metrics/plugin_metrics_provider.cc b/chrome/browser/metrics/plugin_metrics_provider.cc
index aaa2f5fc9ab25b16e376c87e1c096a19d586b514..ebd235a596b0df345df8e5b786581d3058f8c793 100644
--- a/chrome/browser/metrics/plugin_metrics_provider.cc
+++ b/chrome/browser/metrics/plugin_metrics_provider.cc
@@ -144,8 +144,8 @@
metrics::SystemProfileProto::Stability* stability =
system_profile_proto->mutable_stability();
for (const auto& value : *plugin_stats_list) {
- const base::DictionaryValue* plugin_dict;
- if (!value.GetAsDictionary(&plugin_dict)) {
+ base::DictionaryValue* plugin_dict;
+ if (!value->GetAsDictionary(&plugin_dict)) {
NOTREACHED();
continue;
}
@@ -210,9 +210,9 @@
base::ListValue* plugins = update.Get();
DCHECK(plugins);
- for (auto& value : *plugins) {
+ for (const auto& value : *plugins) {
base::DictionaryValue* plugin_dict;
- if (!value.GetAsDictionary(&plugin_dict)) {
+ if (!value->GetAsDictionary(&plugin_dict)) {
NOTREACHED();
continue;
}
« no previous file with comments | « chrome/browser/media_galleries/media_galleries_preferences_unittest.cc ('k') | chrome/browser/net/predictor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698