Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6492)

Unified Diff: chromecast/crash/linux/crash_testing_utils.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/importer/nss_decryptor.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/crash_testing_utils.cc
diff --git a/chromecast/crash/linux/crash_testing_utils.cc b/chromecast/crash/linux/crash_testing_utils.cc
index 6ba362fd4658fcc860a4ae97b522e7f3237622be..4649fc9924fa222d5cae21ebd953222f712c13b0 100644
--- a/chromecast/crash/linux/crash_testing_utils.cc
+++ b/chromecast/crash/linux/crash_testing_utils.cc
@@ -63,7 +63,7 @@
std::string lockfile;
for (const auto& elem : *contents) {
- std::unique_ptr<std::string> dump_info = SerializeToJson(elem);
+ std::unique_ptr<std::string> dump_info = SerializeToJson(*elem);
RCHECK(dump_info, -1, "Failed to serialize DumpInfo");
lockfile += *dump_info;
lockfile += "\n"; // Add line seperatators
@@ -95,7 +95,7 @@
dumps->clear();
for (const auto& elem : *dump_list) {
- std::unique_ptr<DumpInfo> dump(new DumpInfo(&elem));
+ std::unique_ptr<DumpInfo> dump(new DumpInfo(elem.get()));
RCHECK(dump->valid(), false, "Invalid DumpInfo");
dumps->push_back(std::move(dump));
}
« no previous file with comments | « chrome/utility/importer/nss_decryptor.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698