Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: extensions/common/api/declarative/declarative_manifest_data.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | extensions/common/extension_l10n_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/declarative/declarative_manifest_data.cc
diff --git a/extensions/common/api/declarative/declarative_manifest_data.cc b/extensions/common/api/declarative/declarative_manifest_data.cc
index 310113098de1cc501a8bf0177c0d95d845e7b9f8..13bfdcc56f11a5344a8e48c5f6b1be55650a4d46 100644
--- a/extensions/common/api/declarative/declarative_manifest_data.cc
+++ b/extensions/common/api/declarative/declarative_manifest_data.cc
@@ -129,9 +129,9 @@
for (const auto& element : *list) {
const base::DictionaryValue* dict = nullptr;
- if (!element.GetAsDictionary(&dict)) {
+ if (!element->GetAsDictionary(&dict)) {
error_builder.Append("expected dictionary, got %s",
- base::Value::GetTypeName(element.GetType()));
+ base::Value::GetTypeName(element->GetType()));
return std::unique_ptr<DeclarativeManifestData>();
}
std::string event;
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | extensions/common/extension_l10n_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698